Fields

hardware None
os None

Parameters

Fields

NameValue

Parameters

NameValue
git_commit commit a5a0d880736f5dc6a566374bc3b3ca0d86901510
Author: Sam Clegg <sbc@chromium.org>
Date: Tue Jun 17 14:07:16 2025 -0700

[libc++] Remove trailing newline from _LIBCPP_ASSERTION_HANDLER calls (#143573)

This newline was originally added in https://reviews.llvm.org/D142184
but I think updating `__libcpp_verbose_abort` to add newline instead is
more consistent, and works for other callers of `_LIBCPP_VERBOSE_ABORT`.

The `_LIBCPP_ASSERTION_HANDLER` calls through to either
`_LIBCPP_VERBOSE_ABORT` macro or the `__builtin_verbose_trap`. From what
I can tell neither of these function expect a trailing newline (at least
none of the usage of `_LIBCPP_VERBOSE_ABORT` or `__builtin_verbose_trap`
that I can find include a trailing newline except `_LIBCPP_ASSERTION_HANDLER`).

I noticed this discrepancy when working on
https://github.com/emscripten-core/emscripten/pull/24543
Filter

ldionne-old-macbook-results test results

Run Order Start Time Duration
Current 541334 2025-12-16T16:40:01 0:00:00
Previous 541326 2025-12-16T16:40:01 0:00:00
Baseline 485288 2025-12-16T16:40:01 0:00:00


Tests Summary

Status Group # # (B)
Performance Regressions 4 0
Performance Improvements 1 0
Added Tests 1 18
Unchanged Tests 84 72
Total Tests 90

Performance Regressions - execution_time Δ Previous Current σ Δ (B) σ (B)
753_ns3_r 1.41% 10.722 10.873 - 0.00% -
710_omnetpp_r 1.33% 8.347 8.458 - 0.00% -
723_llvm_r 1.17% 11.449 11.583 - 0.00% -
734_vpr_r 1.05% 15.252 15.412 - 0.00% -

Performance Improvements - execution_time Δ Previous Current σ Δ (B) σ (B)
737_gmsh_r -1.31% 13.355 13.179 - 0.00% -

Added Tests - execution_time
735_gem5_r

Added Tests - execution_time
706_stockfish_r
707_ntest_r
709_cactus_r
710_omnetpp_r
721_gcc_r
723_llvm_r
727_cppcheck_r
729_abc_r
731_astcenc_r
734_vpr_r
735_gem5_r
736_ocio_r
737_gmsh_r
748_flightdm_r
750_sealcrypto_r
753_ns3_r
766_femflow_r
767_nest_r


Report Time: 0.13s
Name Current %
706_stockfish_r 22.193 -
707_ntest_r 18.022 -
709_cactus_r 19.790 -
710_omnetpp_r 8.458 1.33%
721_gcc_r 13.069 -
723_llvm_r 11.583 1.17%
727_cppcheck_r 24.989 -
729_abc_r 18.918 -
731_astcenc_r 10.071 -
734_vpr_r 15.412 1.05%
735_gem5_r 14.192 -
736_ocio_r 16.329 -
737_gmsh_r 13.179 -1.31%
748_flightdm_r 8.904 -
750_sealcrypto_r 18.509 -
753_ns3_r 10.873 1.41%
766_femflow_r 12.859 -
767_nest_r 14.294 -
Geometric Mean 14.443 -