Fields

hardware None
os None

Parameters

Fields

NameValue

Parameters

NameValue
git_commit commit a0c00ccd5ff180c721def8001c870338d5de319e
Author: Hristo Hristov <hghristov.rmm@gmail.com>
Date: Sun Jun 15 07:45:48 2025 +0300

[libc++] P2944R3: Constrained comparisons - update `reference_wrapper` implementation (#139368)

Updates the implementation `std::reference_wrapper` -
[P2944R3](https://wg21.link/P2944R3) as discussed in
https://github.com/llvm/llvm-project/pull/117664#discussion_r1857826166
This PR also refactors the tests in preparation to implements the
constrained comparisons for `optional`, `variant` etc.

- Moves the test helpers (concepts and types) for testing constrained
comparisons to `test_comparisons.h`.
- Updates the `std::reference_wrapper` implementation to use the concept
`__core_convertible_to<bool>` as per comments in #135759.

Closes #138233

# References:
- [refwrap.comparisons](https://wg21.link/refwrap.comparisons)

---------

Co-authored-by: Hristo Hristov <zingam@outlook.com>
Co-authored-by: Nikolas Klauser <nikolasklauser@berlin.de>
Filter

ldionne-old-macbook-results test results

Run Order Start Time Duration
Current 541010 2025-12-16T16:40:01 0:00:00
Previous 540766 2025-12-16T16:40:01 0:00:00
Baseline 485288 2025-12-16T16:40:01 0:00:00


Tests Summary

Status Group # # (B)
Performance Regressions 6 0
Performance Improvements 1 0
Added Tests 0 18
Unchanged Tests 83 72
Total Tests 90

Performance Regressions - execution_time Δ Previous Current σ Δ (B) σ (B)
735_gem5_r 2.53% 14.057 14.413 - 0.00% -
729_abc_r 2.25% 18.747 19.170 - 0.00% -
737_gmsh_r 2.08% 13.115 13.387 - 0.00% -
753_ns3_r 1.62% 10.703 10.876 - 0.00% -
710_omnetpp_r 1.55% 8.466 8.596 - 0.00% -
748_flightdm_r 1.26% 8.925 9.037 - 0.00% -

Performance Improvements - execution_time Δ Previous Current σ Δ (B) σ (B)
767_nest_r -1.33% 14.357 14.166 - 0.00% -

Added Tests - execution_time
706_stockfish_r
707_ntest_r
709_cactus_r
710_omnetpp_r
721_gcc_r
723_llvm_r
727_cppcheck_r
729_abc_r
731_astcenc_r
734_vpr_r
735_gem5_r
736_ocio_r
737_gmsh_r
748_flightdm_r
750_sealcrypto_r
753_ns3_r
766_femflow_r
767_nest_r


Report Time: 0.11s
Name Current %
706_stockfish_r 22.280 -
707_ntest_r 18.071 -
709_cactus_r 19.789 -
710_omnetpp_r 8.596 1.55%
721_gcc_r 13.076 -
723_llvm_r 11.622 -
727_cppcheck_r 24.812 -
729_abc_r 19.170 2.25%
731_astcenc_r 10.186 -
734_vpr_r 15.435 -
735_gem5_r 14.413 2.53%
736_ocio_r 16.327 -
737_gmsh_r 13.387 2.08%
748_flightdm_r 9.037 1.26%
750_sealcrypto_r 18.517 -
753_ns3_r 10.876 1.62%
766_femflow_r 12.862 -
767_nest_r 14.166 -1.33%
Geometric Mean 14.510 -