Fields

hardware None
os None

Parameters

Fields

NameValue

Parameters

NameValue
git_commit commit 9965f3d337bba09fbf2497a78123957fdaee0ffa
Author: Damien L-G <dalg24@gmail.com>
Date: Mon Apr 7 15:25:45 2025 -0400

[libc++] Improve diagnostic when violating `std::atomic` trivially copyable mandates (#131754)

When attempting to instantiate `std::atomic` with a non trivially
copyable type, one gets errors from instantiating internals before the
actual static assertion that check the template parameter type
requirements.

The `verify` test for it had a `// ADDITIONAL_COMPILE_FLAGS: -Xclang
-verify-ignore-unexpected=error` directive to work around this issue.
The changes I propose enable us to drop that directive.
As I understand it, the `verify` test was misplaced so I moved it to
`test/{std -> libcxx}/atomics`.

(I ran into this while working on #121414 in which we would add another
static assertion in `__check_atomic_mandates`)
Filter

ldionne-old-macbook-results test results

Run Order Start Time Duration
Current 533266 2025-12-16T16:40:01 0:00:00
Previous 533161 2025-12-16T16:40:01 0:00:00
Baseline 485288 2025-12-16T16:40:01 0:00:00


Tests Summary

Status Group # # (B)
Performance Regressions 2 0
Performance Improvements 3 0
Added Tests 0 18
Unchanged Tests 85 72
Total Tests 90

Performance Regressions - execution_time Δ Previous Current σ Δ (B) σ (B)
710_omnetpp_r 1.15% 8.351 8.447 - 0.00% -
734_vpr_r 1.03% 15.237 15.394 - 0.00% -

Performance Improvements - execution_time Δ Previous Current σ Δ (B) σ (B)
748_flightdm_r -2.30% 9.085 8.877 - 0.00% -
735_gem5_r -1.54% 13.997 13.781 - 0.00% -
737_gmsh_r -1.08% 13.178 13.035 - 0.00% -

Added Tests - execution_time
706_stockfish_r
707_ntest_r
709_cactus_r
710_omnetpp_r
721_gcc_r
723_llvm_r
727_cppcheck_r
729_abc_r
731_astcenc_r
734_vpr_r
735_gem5_r
736_ocio_r
737_gmsh_r
748_flightdm_r
750_sealcrypto_r
753_ns3_r
766_femflow_r
767_nest_r


Report Time: 0.12s
Name Current %
706_stockfish_r 22.058 -
707_ntest_r 17.869 -
709_cactus_r 19.819 -
710_omnetpp_r 8.447 1.15%
721_gcc_r 12.950 -
723_llvm_r 11.536 -
727_cppcheck_r 24.472 -
729_abc_r 18.630 -
731_astcenc_r 10.011 -
734_vpr_r 15.394 1.03%
735_gem5_r 13.781 -1.54%
736_ocio_r 16.129 -
737_gmsh_r 13.035 -1.08%
748_flightdm_r 8.877 -2.30%
750_sealcrypto_r 18.323 -
753_ns3_r 10.706 -
766_femflow_r 12.781 -
767_nest_r 14.190 -
Geometric Mean 14.311 -