Fields

hardware None
os None

Parameters

Fields

NameValue

Parameters

NameValue
git_commit commit 979e9361f0e0426e555c94cb8b1a64c655805765
Author: Peng Liu <winner245@hotmail.com>
Date: Fri Dec 13 09:28:30 2024 -0500

[libc++] Fix improper static_cast in std::deque and __split_buffer (#119106)

This PR addresses the improper use of `static_cast` to `size_t` where
`size_type` is intended. Although the `size_type` member type of STL
containers is usually a synonym of `std::size_t`, there is no guarantee
that they are always equivalent. The C++ standard does not mandate this
equivalence.

In libc++'s implementations of `std::deque`, `std::vector`, and
`__split_buffer`, the `size_type` member type is defined as
`std::allocator_traits<allocator_type>::size_type`, which is either
`allocator_type::size_type` if available or
`std::make_unsigned<difference_type>::type`. While it is true for
`std::allocator` that the `size_type` member type is `std::size_t`, for
user-defined allocator types, they may mismatch. This justifies the need
to replace `static_cast<size_t>` with `static_cast<size_type>` in this
PR.
Filter

ldionne-old-macbook-results test results

Run Order Start Time Duration
Current 521352 2025-12-16T16:40:01 0:00:00
Previous 521340 2025-12-16T16:40:01 0:00:00
Baseline 485288 2025-12-16T16:40:01 0:00:00


Tests Summary

Status Group # # (B)
Performance Regressions 1 0
Performance Improvements 5 0
Added Tests 1 18
Unchanged Tests 83 72
Total Tests 90

Performance Regressions - execution_time Δ Previous Current σ Δ (B) σ (B)
753_ns3_r 1.43% 10.280 10.427 - 0.00% -

Performance Improvements - execution_time Δ Previous Current σ Δ (B) σ (B)
748_flightdm_r -1.74% 9.056 8.898 - 0.00% -
707_ntest_r -1.67% 18.100 17.798 - 0.00% -
737_gmsh_r -1.65% 13.247 13.028 - 0.00% -
710_omnetpp_r -1.51% 8.529 8.400 - 0.00% -
767_nest_r -1.21% 14.352 14.178 - 0.00% -

Added Tests - execution_time
735_gem5_r

Added Tests - execution_time
706_stockfish_r
707_ntest_r
709_cactus_r
710_omnetpp_r
721_gcc_r
723_llvm_r
727_cppcheck_r
729_abc_r
731_astcenc_r
734_vpr_r
735_gem5_r
736_ocio_r
737_gmsh_r
748_flightdm_r
750_sealcrypto_r
753_ns3_r
766_femflow_r
767_nest_r


Report Time: 0.06s
Name Current %
706_stockfish_r 22.055 -
707_ntest_r 17.798 -1.67%
709_cactus_r 19.720 -
710_omnetpp_r 8.400 -1.51%
721_gcc_r 12.937 -
723_llvm_r 11.472 -
727_cppcheck_r 24.379 -
729_abc_r 18.654 -
731_astcenc_r 10.017 -
734_vpr_r 15.605 -
735_gem5_r 13.695 -
736_ocio_r 16.182 -
737_gmsh_r 13.028 -1.65%
748_flightdm_r 8.898 -1.74%
750_sealcrypto_r 18.342 -
753_ns3_r 10.427 1.43%
766_femflow_r 12.772 -
767_nest_r 14.178 -1.21%
Geometric Mean 14.281 -