Fields

hardware None
os None

Parameters

Fields

NameValue

Parameters

NameValue
git_commit commit 917ada35cd937ad4104dff89c48398bd796ba6b7
Author: Louis Dionne <ldionne.2@gmail.com>
Date: Thu Oct 10 08:00:01 2024 -0400

[runtimes] Always define cxx_shared, cxx_static & other targets (#80007)

This patch always defines the cxx_shared, cxx_static & other top-level
targets. However, they are marked as EXCLUDE_FROM_ALL when we don't want
to build them. Simply declaring the targets should be of no harm, and it
allows other projects to mention these targets regardless of whether
they end up being built or not.

This patch basically moves the definition of e.g. cxx_shared out of the
`if (LIBCXX_ENABLE_SHARED)` and instead marks it as EXCLUDE_FROM_ALL
conditionally on whether LIBCXX_ENABLE_SHARED is passed. It then does
the same for libunwind and libc++abi targets. I purposefully avoided to
reformat the files (which now has inconsistent indentation) because I
wanted to keep the diff minimal, and I know this is an area of the code
where folks may have downstream diffs. I will re-indent the code
separately once this patch lands.

This is a reapplication of 79ee0342dbf0, which was reverted in
a3539090884c because it broke the TSAN and the Fuchsia builds.

Resolves #77654

Differential Revision: https://reviews.llvm.org/D134221
Filter

ldionne-old-macbook-results test results

Run Order Start Time Duration
Current 514610 2025-12-16T16:40:01 0:00:00
Previous 514536 2025-12-16T16:40:01 0:00:00
Baseline 485288 2025-12-16T16:40:01 0:00:00


Tests Summary

Status Group # # (B)
Total Tests 0

Report Time: 0.16s