Fields

hardware None
os None

Parameters

Fields

NameValue

Parameters

NameValue
git_commit commit 3a63407686313f46f9abc664fd10b01f4359ee27
Author: Louis Dionne <ldionne.2@gmail.com>
Date: Wed Nov 20 00:35:14 2024 +0100

[libc++] Make __atomic_base into an implementation detail of std::atomic (#115764)

The __atomic_base base class is only useful to conditionalize the
operations we provide inside std::atomic. It shouldn't be used directly
from other places in the library which can use std::atomic directly
instead.

Since we've granularized our includes, using std::atomic directly should
not make much of a difference compile-time wise.

This patch starts using std::atomic directly from other classes like
std::barrier and std::latch. Changing this shouldn't be an ABI break
since both classes have the same size and layout.

The benefits of this patch are isolating other parts of the code base
from implementation details of std::atomic and simplifying the mental
model for std::atomic's layers of implementation by making it clear that
__atomic_base is only an implementation detail of std::atomic.
Filter

ldionne-old-macbook-results test results

Run Order Start Time Duration
Current 518779 2025-12-16T16:40:01 0:00:00
Previous 518627 2025-12-16T16:40:01 0:00:00
Baseline 485288 2025-12-16T16:40:01 0:00:00


Tests Summary

Status Group # # (B)
Performance Regressions 1 0
Performance Improvements 3 0
Added Tests 0 18
Unchanged Tests 86 72
Total Tests 90

Performance Regressions - execution_time Δ Previous Current σ Δ (B) σ (B)
753_ns3_r 1.26% 10.332 10.462 - 0.00% -

Performance Improvements - execution_time Δ Previous Current σ Δ (B) σ (B)
767_nest_r -3.97% 14.848 14.258 - 0.00% -
727_cppcheck_r -1.76% 25.310 24.863 - 0.00% -
748_flightdm_r -1.65% 9.010 8.861 - 0.00% -

Added Tests - execution_time
706_stockfish_r
707_ntest_r
709_cactus_r
710_omnetpp_r
721_gcc_r
723_llvm_r
727_cppcheck_r
729_abc_r
731_astcenc_r
734_vpr_r
735_gem5_r
736_ocio_r
737_gmsh_r
748_flightdm_r
750_sealcrypto_r
753_ns3_r
766_femflow_r
767_nest_r


Report Time: 0.13s
Name Current %
706_stockfish_r 22.071 -
707_ntest_r 17.999 -
709_cactus_r 19.687 -
710_omnetpp_r 8.461 -
721_gcc_r 12.952 -
723_llvm_r 11.533 -
727_cppcheck_r 24.863 -1.76%
729_abc_r 18.721 -
731_astcenc_r 10.031 -
734_vpr_r 15.585 -
735_gem5_r 13.670 -
736_ocio_r 16.183 -
737_gmsh_r 13.035 -
748_flightdm_r 8.861 -1.65%
750_sealcrypto_r 18.347 -
753_ns3_r 10.462 1.26%
766_femflow_r 12.781 -
767_nest_r 14.258 -3.97%
Geometric Mean 14.322 -