Fields

hardware None
os None

Parameters

Fields

NameValue

Parameters

NameValue
git_commit commit d05ab119e188be99697f142a02c6b71137fde082
Author: Louis Dionne <ldionne.2@gmail.com>
Date: Tue May 6 15:44:26 2025 -0400

[libc++] Remove redundant and somewhat confusing assertions around advance() (#133276)

The std::advance function has a clear precondition that it can only be
called with a negative distance when a bidirectional iterator is used.
However, prev() and next() don't have such preconditions explicitly,
they inherit it from calling advance().

This patch removes assertions in prev() and next() that were duplicates
of similar ones in advance(), and removes a copy-pasted comment that was
trying to justify the use of _LIBCPP_ASSERT_PEDANTIC but IMO is creating
confusion with little benefit.
Filter

ldionne-old-macbook-results test results

Run Order Start Time Duration
Current 536478 2025-12-16T16:40:01 0:00:00
Previous 536406 2025-12-16T16:40:01 0:00:00
Baseline 485288 2025-12-16T16:40:01 0:00:00


Tests Summary

Status Group # # (B)
Performance Regressions 2 0
Performance Improvements 2 0
Added Tests 1 18
Unchanged Tests 85 72
Total Tests 90

Performance Regressions - execution_time Δ Previous Current σ Δ (B) σ (B)
723_llvm_r 1.36% 11.465 11.621 - 0.00% -
766_femflow_r 1.15% 12.833 12.981 - 0.00% -

Performance Improvements - execution_time Δ Previous Current σ Δ (B) σ (B)
729_abc_r -1.66% 18.822 18.508 - 0.00% -
737_gmsh_r -1.24% 13.055 12.892 - 0.00% -

Added Tests - execution_time
735_gem5_r

Added Tests - execution_time
706_stockfish_r
707_ntest_r
709_cactus_r
710_omnetpp_r
721_gcc_r
723_llvm_r
727_cppcheck_r
729_abc_r
731_astcenc_r
734_vpr_r
735_gem5_r
736_ocio_r
737_gmsh_r
748_flightdm_r
750_sealcrypto_r
753_ns3_r
766_femflow_r
767_nest_r


Report Time: 0.06s
Name Current %
706_stockfish_r 22.081 -
707_ntest_r 17.980 -
709_cactus_r 19.672 -
710_omnetpp_r 8.499 -
721_gcc_r 13.021 -
723_llvm_r 11.621 1.36%
727_cppcheck_r 24.975 -
729_abc_r 18.508 -1.66%
731_astcenc_r 10.131 -
734_vpr_r 15.460 -
735_gem5_r 14.149 -
736_ocio_r 16.380 -
737_gmsh_r 12.892 -1.24%
748_flightdm_r 9.031 -
750_sealcrypto_r 18.513 -
753_ns3_r 10.725 -
766_femflow_r 12.981 1.15%
767_nest_r 14.129 -
Geometric Mean 14.407 -